linux-kernel - Re: [PATCH] LoongArch: vDSO: Disable UBSAN instrumentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H524mSc5SgiwVF3aATFkrp0_xo2W7-5sXk0nXyN+rBzrA@mail.gmail.com>
Date: Wed, 31 Jan 2024 14:05:34 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Kees Cook <keescook@...omium.org>
Cc: kernel test robot <lkp@...el.com>, WANG Xuerui <kernel@...0n.name>, 
	Vincenzo Frascino <vincenzo.frascino@....com>, Nathan Chancellor <nathan@...nel.org>, 
	Masahiro Yamada <masahiroy@...nel.org>, Fangrui Song <maskray@...gle.com>, loongarch@...ts.linux.dev, 
	Thomas Gleixner <tglx@...utronix.de>, Qing Zhang <zhangqing@...ngson.cn>, 
	Feiyang Chen <chenfeiyang@...ngson.cn>, linux-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] LoongArch: vDSO: Disable UBSAN instrumentation

Queued, thanks.

Huacai

On Wed, Jan 31, 2024 at 7:31 AM Kees Cook <keescook@...omium.org> wrote:
>
> The vDSO executes in userspace, so the kernel's UBSAN should not
> instrument it. Solves these kind of build errors:
>
>   loongarch64-linux-ld: arch/loongarch/vdso/vgettimeofday.o: in function `vdso_shift_ns':
>   lib/vdso/gettimeofday.c:23:(.text+0x3f8): undefined reference to `__ubsan_handle_shift_out_of_bounds'
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401310530.lZHCj1Zl-lkp@intel.com/
> Cc: Huacai Chen <chenhuacai@...nel.org>
> Cc: WANG Xuerui <kernel@...0n.name>
> Cc: Vincenzo Frascino <vincenzo.frascino@....com>
> Cc: Nathan Chancellor <nathan@...nel.org>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Fangrui Song <maskray@...gle.com>
> Cc: loongarch@...ts.linux.dev
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  arch/loongarch/vdso/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
> index c74c9921304f..f597cd08a96b 100644
> --- a/arch/loongarch/vdso/Makefile
> +++ b/arch/loongarch/vdso/Makefile
> @@ -2,6 +2,7 @@
>  # Objects to go into the VDSO.
>
>  KASAN_SANITIZE := n
> +UBSAN_SANITIZE := n
>  KCOV_INSTRUMENT := n
>
>  # Include the generic Makefile to check the built vdso.
> --
> 2.34.1
>