linux-kernel - RE: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <010301da540b$accfe490$066fadb0$@samsung.com>
Date: Wed, 31 Jan 2024 11:36:44 +0530
From: "Aakarsh Jain" <aakarsh.jain@...sung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-media@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Cc: <m.szyprowski@...sung.com>, <andrzej.hajda@...el.com>,
	<mchehab@...nel.org>, <hverkuil-cisco@...all.nl>,
	<krzysztof.kozlowski+dt@...aro.org>, <robh+dt@...nel.org>,
	<conor+dt@...nel.org>, <linux-samsung-soc@...r.kernel.org>,
	<andi@...zian.org>, <gost.dev@...sung.com>, <alim.akhtar@...sung.com>,
	<pankaj.dubey@...sung.com>
Subject: RE: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt binding



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: 30 January 2024 19:57
> To: Aakarsh Jain <aakarsh.jain@...sung.com>; linux-arm-
> kernel@...ts.infradead.org; linux-media@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org
> Cc: m.szyprowski@...sung.com; andrzej.hajda@...el.com;
> mchehab@...nel.org; hverkuil-cisco@...all.nl;
> krzysztof.kozlowski+dt@...aro.org; robh+dt@...nel.org;
> conor+dt@...nel.org; linux-samsung-soc@...r.kernel.org;
> andi@...zian.org; gost.dev@...sung.com; alim.akhtar@...sung.com;
> pankaj.dubey@...sung.com
> Subject: Re: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt
> binding
> 
> On 30/01/2024 15:25, Krzysztof Kozlowski wrote:
> > On 30/01/2024 13:57, Aakarsh Jain wrote:
> >> Commit "538af6e5856b" which convert s5p-mfc bindings to
> >
> > Please run scripts/checkpatch.pl and fix reported warnings. Some
> > warnings can be ignored, but the code here looks like it needs a fix.
> > Feel free to get in touch if the warning is not clear.
> >
I am getting below warning while running scripts/checkpatch.pl on this patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
deleted file mode 100644

total: 0 errors, 1 warnings, 0 lines checked

I think this can be ignored.
> >> json-schema is already merged. Remove "s5p-mfc.txt" file.
> >>
> >> Signed-off-by: Aakarsh Jain <aakarsh.jain@...sung.com>
> >> ---
> >>  Documentation/devicetree/bindings/media/s5p-mfc.txt | 0
> >
> > Why you did not remove it in the first place? Your diff from
> > 538af6e5856b is so confusing.
> 
I missed it before. Will add Fixes tag.

> Also, add fixes tag.
> 
Sure.

Thanks for review!
> Best regards,
> Krzysztof