linux-kernel - Re: [PATCH v4 12/12] nvmet-fc: use RCU list iterator for assoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240131062952.GK16225@lst.de>
Date: Wed, 31 Jan 2024 07:29:52 +0100
From: Christoph Hellwig <hch@....de>
To: Daniel Wagner <dwagner@...e.de>
Cc: James Smart <james.smart@...adcom.com>, Keith Busch <kbusch@...nel.org>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 12/12] nvmet-fc: use RCU list iterator for assoc_list

> +		list_for_each_entry_rcu(tmpassoc, &tgtport->assoc_list, a_list) {

please avoid the overly long line.

Also in general the (rcu)lock, list walk to find something, return
patterns tend to benefit from being factored into a little helper.
Not sure if that really fits here, though.