linux-kernel - Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY6dS_sedemVk-fGzhsyT_B5dXAeFX-PO+GcvCrt9Je5w@mail.gmail.com>
Date: Wed, 31 Jan 2024 08:37:40 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Yan Zhao <yan.y.zhao@...el.com>
Cc: arnd@...db.de, guoren@...nel.org, bcain@...cinc.com, jonas@...thpole.se, 
	stefan.kristiansson@...nalahti.fi, shorne@...il.com, 
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org, 
	linux-openrisc@...r.kernel.org
Subject: Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt

On Wed, Jan 31, 2024 at 7:25 AM Yan Zhao <yan.y.zhao@...el.com> wrote:

> This is a tiny fix to pfn_to_virt() for some platforms.
>
> The original implementaion of pfn_to_virt() takes PFN instead of PA as the
> input to macro __va, with PAGE_SHIFT applying to the converted VA, which
> is not right under most conditions, especially when there's an offset in
> __va.

Ooops that's right, I wonder why I got it wrong.
Arithmetic made it not regress :/
Thank you so much for fixing this Yan!

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Arnd: I think you can take most of them through the arch tree.

Yours,
Linus Walleij