[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <378befa5-d211-42c1-97fc-47c1d8bb0f95@linaro.org>
Date: Wed, 31 Jan 2024 08:41:49 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Mao Jinlong <quic_jinlmao@...cinc.com>,
Suzuki K Poulose <suzuki.poulose@....com>, Mike Leach
<mike.leach@...aro.org>, James Clark <james.clark@....com>,
Leo Yan <leo.yan@...aro.org>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>
Cc: coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org, Tingwei Zhang <quic_tingweiz@...cinc.com>,
Yuanfang Zhang <quic_yuanfang@...cinc.com>,
Tao Zhang <quic_taozha@...cinc.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add coresight nodes for sm8450
On 19/01/2024 10:24, Mao Jinlong wrote:
> Add coresight components on Qualcomm SM8450 Soc. The components include
> TMC ETF/ETR, ETE, STM, TPDM, CTI.
>
> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
> ---
> + funnel@...10000 {
> + compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +
> + reg = <0x0 0x13810000 0x0 0x1000>;
> +
> + clocks = <&aoss_qmp>;
> + clock-names = "apb_pclk";
> +
> + in-ports {
> +
> + port {
> + funnel_apss_in_funnel_ete: endpoint {
> + remote-endpoint =
> + <&funnel_ete_out_funnel_apss>;
> + };
> + };
> +
> + };
> +
> + out-ports {
> + port {
> + funnel_apss_out_funnel_in1: endpoint {
> + remote-endpoint =
> + <&funnel_in1_in_funnel_apss>;
> + };
> + };
> +
You have several redundant lines, everywhere. Clean up to match coding
style. There is no blank line between trailing }; and another trailing };.
> + };
> + };
Best regards,
Krzysztof
Powered by blists - more mailing lists