linux-kernel - Re: [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69783a3d-a158-4582-93d2-3f120e2e9ea6@linaro.org>
Date: Wed, 31 Jan 2024 09:32:47 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Henrik Grimler <henrik@...mler.se>
Cc: Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Marek Szyprowski <m.szyprowski@...sung.com>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort
 node properties

On 31/01/2024 09:25, Henrik Grimler wrote:
> Hi Krzysztof,
> 
> On Wed, Jan 31, 2024 at 08:19:39AM +0100, Krzysztof Kozlowski wrote:
>> On 30/01/2024 21:40, Henrik Grimler wrote:
>>> Sort all node properties according to dts coding style guidelines, to
>>> make dtsi easier to follow.
>>>
>>> Signed-off-by: Henrik Grimler <henrik@...mler.se>
>>> ---
>>>  .../dts/samsung/exynos5420-galaxy-tab-common.dtsi  | 23 +++++++++++-----------
>>>  1 file changed, 11 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> index f525b2f5e4e0..0c1aeafc025b 100644
>>> --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> @@ -103,8 +103,8 @@ &cpu4 {
>>>  };
>>>  
>>>  &gpu {
>>> -	status = "okay";
>>>  	mali-supply = <&buck4_reg>;
>>> +	status = "okay";
>>
>> Such changes should come from a tool, but since we do not have them, I
>> don't want to bother with properties re-shuffling.
> 
> Noted, thanks. I will drop this patch and send a v2 in a few hours.

No need for v2, unless some other comments pop up. I will just apply #2
and #3 from this set.

Best regards,
Krzysztof