linux-kernel - Re: [PATCH v2 2/2] dt-bindings: pinctrl: qcom: consolidate functions to match with driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf2ea585-0fb1-443a-a467-60f8b5d28174@quicinc.com>
Date: Wed, 31 Jan 2024 16:40:17 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <linus.walleij@...aro.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: pinctrl: qcom: consolidate functions
 to match with driver



On 1/31/2024 4:34 PM, Krzysztof Kozlowski wrote:
> On 31/01/2024 09:24, Tengfei Fan wrote:
>>
>>
>> On 1/29/2024 7:24 PM, Krzysztof Kozlowski wrote:
>>> On 29/01/2024 10:25, Tengfei Fan wrote:
>>>> Consolidate functions to match with SM4450 pinctrl driver, because
>>>> consolidate functions are being used in SM4450 pinctrl driver.
>>>
>>> It's very difficult to see what changed from the diff, so please explain
>>> brieflyl changes here.
>>>
>>> What is that "consolidate functions" that you use in the driver?
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> please help to comfirm that the following description as commit message
>> whether it covers your concerns:
>>
>> Pin alternative functions are consolidated(like: atest_char, phase_flag,
>> qdss_gpio etc.) in SM4450 pinctrl driver while they are still split in
>> DeviceTree binding file. SM4450 pinctrl function is broken if current
>> binding doc is followed. Update SM4450 pinctrl DeviceTree binding doc to
>> align with driver.
> 
> Please list the functions which are being removed and added. I usually
> do not expect such commit msg, but this is an exception: diff is tricky
> to parse.
> 
> Best regards,
> Krzysztof
> 

yes, I understand your concerns. I will list all the functions that need 
to be updated.

-- 
Thx and BRs,
Tengfei Fan