linux-kernel - Re: [PATCH] RAS/AMD/ATL: Fix array overflow in get_logical_coh_st_fabric_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240131084937.GAZboJoRjQLxlANlw1@fat_crate.local>
Date: Wed, 31 Jan 2024 09:49:37 +0100
From: Borislav Petkov <bp@...en8.de>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Muralidhara M K <muralidhara.mk@....com>,
	Yazen Ghannam <Yazen.Ghannam@....com>,
	Tony Luck <tony.luck@...el.com>, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] RAS/AMD/ATL: Fix array overflow in
 get_logical_coh_st_fabric_id_mi300()

On Wed, Jan 31, 2024 at 11:24:25AM +0300, Dan Carpenter wrote:
> Check against ARRAY_SIZE() which is the number of elements instead of
> sizeof() which is the number of bytes.  Otherwise we potentially read
> beyond the end of the phy_to_log_coh_st_map_mi300[] array.
> 
> Fixes: 453f0ae79732 ("RAS/AMD/ATL: Add MI300 support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/ras/amd/atl/denormalize.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ras/amd/atl/denormalize.c b/drivers/ras/amd/atl/denormalize.c
> index d5d0e1fda159..49a900e066f1 100644
> --- a/drivers/ras/amd/atl/denormalize.c
> +++ b/drivers/ras/amd/atl/denormalize.c
> @@ -405,7 +405,7 @@ static const u16 phy_to_log_coh_st_map_mi300[] = {
>  
>  static u16 get_logical_coh_st_fabric_id_mi300(struct addr_ctx *ctx)
>  {
> -	if (ctx->inst_id >= sizeof(phy_to_log_coh_st_map_mi300)) {
> +	if (ctx->inst_id >= ARRAY_SIZE(phy_to_log_coh_st_map_mi300)) {
>  		atl_debug(ctx, "Instance ID out of range");
>  		return ~0;
>  	}
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette