linux-kernel - Re: [PATCH net-next v4 08/11] stmmac: intel: configure SerDes according to the interface mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 31 Jan 2024 12:58:32 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
cc: Rajneesh Bhardwaj <irenic.rajneesh@...il.com>, 
    David E Box <david.e.box@...ux.intel.com>, 
    Hans de Goede <hdegoede@...hat.com>, Mark Gross <markgross@...nel.org>, 
    Alexandre Torgue <alexandre.torgue@...s.st.com>, 
    Jose Abreu <Jose.Abreu@...opsys.com>, 
    "David S . Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
    Paolo Abeni <pabeni@...hat.com>, 
    Maxime Coquelin <mcoquelin.stm32@...il.com>, 
    Richard Cochran <richardcochran@...il.com>, 
    Russell King <linux@...linux.org.uk>, Alexei Starovoitov <ast@...nel.org>, 
    Daniel Borkmann <daniel@...earbox.net>, 
    Jesper Dangaard Brouer <hawk@...nel.org>, 
    John Fastabend <john.fastabend@...il.com>, Andrew Lunn <andrew@...n.ch>, 
    Heiner Kallweit <hkallweit1@...il.com>, 
    Philipp Zabel <p.zabel@...gutronix.de>, 
    Andrew Halaney <ahalaney@...hat.com>, 
    Simon Horman <simon.horman@...igine.com>, 
    Serge Semin <fancer.lancer@...il.com>, Netdev <netdev@...r.kernel.org>, 
    LKML <linux-kernel@...r.kernel.org>, 
    linux-stm32@...md-mailman.stormreply.com, 
    linux-arm-kernel@...ts.infradead.org, platform-driver-x86@...r.kernel.org, 
    linux-hwmon@...r.kernel.org, bpf@...r.kernel.org, 
    Voon Wei Feng <weifeng.voon@...el.com>, 
    Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>, 
    Lai Peter Jun Ann <jun.ann.lai@...el.com>, 
    Abdul Rahim Faizal <faizal.abdul.rahim@...el.com>
Subject: Re: [PATCH net-next v4 08/11] stmmac: intel: configure SerDes
 according to the interface mode

On Mon, 29 Jan 2024, Choong Yong Liang wrote:

> From: "Tan, Tee Min" <tee.min.tan@...ux.intel.com>
> 
> Intel platform will configure the SerDes through PMC api based on the
> provided interface mode.
> 
> This patch adds several new functions below:-
> - intel_tsn_interface_is_available(): This new function reads FIA lane
>   ownership registers and common lane registers through IPC commands
>   to know which lane the mGbE port is assigned to.
> - intel_config_serdes(): To configure the SerDes based on the assigned
>   lane and latest interface mode, it sends IPC command to the PMC through
>   PMC driver/API. The PMC acts as a proxy for R/W on behalf of the driver.
> - intel_set_reg_access(): Set the register access to the available TSN
>   interface.
> 
> Signed-off-by: Tan, Tee Min <tee.min.tan@...ux.intel.com>
> Signed-off-by: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/Kconfig   |   1 +
>  .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 113 +++++++++++++++++-
>  .../net/ethernet/stmicro/stmmac/dwmac-intel.h |  75 ++++++++++++
>  3 files changed, 188 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index 85dcda51df05..be423fb2b46c 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -273,6 +273,7 @@ config DWMAC_INTEL
>  	default X86
>  	depends on X86 && STMMAC_ETH && PCI
>  	depends on COMMON_CLK
> +	select INTEL_PMC_IPC

INTEL_PMC_IPC has depends on ACPI but selecting INTEL_PMC_IPC won't 
enforce it AFAIK.

-- 
 i.