linux-kernel - Re: [PATCH 2/2] fnic: move fnic_fnic_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202401311947.cPDhv2xa-lkp@intel.com>
Date: Wed, 31 Jan 2024 19:50:34 +0800
From: kernel test robot <lkp@...el.com>
To: Lee Duncan <leeman.duncan@...il.com>, linux-scsi@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	hare@...e.de, Lee Duncan <lduncan@...e.com>
Subject: Re: [PATCH 2/2] fnic: move fnic_fnic_flush_tx() to a work queue

Hi Lee,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.8-rc2 next-20240131]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lee-Duncan/Revert-scsi-fcoe-Fix-potential-deadlock-on-fip-ctlr_lock/20240131-004656
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link:    https://lore.kernel.org/r/9c51ef07a04413fb2f2bd20f1534f96e004e4e59.1706632031.git.lduncan%40suse.com
patch subject: [PATCH 2/2] fnic: move fnic_fnic_flush_tx() to a work queue
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20240131/202401311947.cPDhv2xa-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240131/202401311947.cPDhv2xa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401311947.cPDhv2xa-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/scsi/fnic/fnic_fcs.c:1194: warning: Function parameter or struct member 'work' not described in 'fnic_flush_tx'
>> drivers/scsi/fnic/fnic_fcs.c:1194: warning: Excess function parameter 'fnic' description in 'fnic_flush_tx'


vim +1194 drivers/scsi/fnic/fnic_fcs.c

5df6d737dd4b0fe Abhijeet Joglekar 2009-04-17  1182  
78112e5558064cb Joe Eykholt       2009-11-03  1183  /**
78112e5558064cb Joe Eykholt       2009-11-03  1184   * fnic_flush_tx() - send queued frames.
78112e5558064cb Joe Eykholt       2009-11-03  1185   * @fnic: fnic device
78112e5558064cb Joe Eykholt       2009-11-03  1186   *
78112e5558064cb Joe Eykholt       2009-11-03  1187   * Send frames that were waiting to go out in FC or Ethernet mode.
78112e5558064cb Joe Eykholt       2009-11-03  1188   * Whenever changing modes we purge queued frames, so these frames should
78112e5558064cb Joe Eykholt       2009-11-03  1189   * be queued for the stable mode that we're in, either FC or Ethernet.
78112e5558064cb Joe Eykholt       2009-11-03  1190   *
78112e5558064cb Joe Eykholt       2009-11-03  1191   * Called without fnic_lock held.
78112e5558064cb Joe Eykholt       2009-11-03  1192   */
7ea34b1ffb4e1aa Hannes Reinecke   2024-01-30  1193  void fnic_flush_tx(struct work_struct *work)
78112e5558064cb Joe Eykholt       2009-11-03 @1194  {
7ea34b1ffb4e1aa Hannes Reinecke   2024-01-30  1195  	struct fnic *fnic = container_of(work, struct fnic, flush_work);
78112e5558064cb Joe Eykholt       2009-11-03  1196  	struct sk_buff *skb;
78112e5558064cb Joe Eykholt       2009-11-03  1197  	struct fc_frame *fp;
5df6d737dd4b0fe Abhijeet Joglekar 2009-04-17  1198  
d9e9ab56b687da0 Brian Uchino      2010-04-09  1199  	while ((skb = skb_dequeue(&fnic->tx_queue))) {
78112e5558064cb Joe Eykholt       2009-11-03  1200  		fp = (struct fc_frame *)skb;
78112e5558064cb Joe Eykholt       2009-11-03  1201  		fnic_send_frame(fnic, fp);
78112e5558064cb Joe Eykholt       2009-11-03  1202  	}
78112e5558064cb Joe Eykholt       2009-11-03  1203  }
5df6d737dd4b0fe Abhijeet Joglekar 2009-04-17  1204  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki