linux-kernel - Re: [PATCH] blackhole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 1 Feb 2024 17:02:18 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Breno Leitao <leitao@...ian.org>
Cc: kuba@...nel.org, davem@...emloft.net, pabeni@...hat.com,
	edumazet@...gle.com, Andrew Morton <akpm@...ux-foundation.org>,
	Mahesh Bandewar <maheshb@...gle.com>, weiwan@...gle.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	horms@...nel.org, andrew@...n.ch, leit@...com
Subject: Re: [PATCH] blackhole_dev: Fix buil warning

s/buil/build/ in the subject.

Also, indicate which tree are you targetting. In this case, should be:
[patch net-next] xxx


Thu, Feb 01, 2024 at 02:32:37PM CET, leitao@...ian.org wrote:
>lib/test_blackhole_dev.c sets a variable that is never read, causing
>this following building warning:
>
>	lib/test_blackhole_dev.c:32:17: warning: variable 'ethh' set but not used [-Wunused-but-set-variable]
>
>Remove the variable struct ethhdr *ethh, which is unused.
>
>Fixes: 509e56b37cc3 ("blackhole_dev: add a selftest")
>Signed-off-by: Breno Leitao <leitao@...ian.org>

The patch itself looks good. Feel free to attach
Reviewed-by: Jiri Pirko <jiri@...dia.com>
with the v2 with fixed subject. Thanks!


>---
> lib/test_blackhole_dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/lib/test_blackhole_dev.c b/lib/test_blackhole_dev.c
>index 4c40580a99a3..f247089d63c0 100644
>--- a/lib/test_blackhole_dev.c
>+++ b/lib/test_blackhole_dev.c
>@@ -29,7 +29,6 @@ static int __init test_blackholedev_init(void)
> {
> 	struct ipv6hdr *ip6h;
> 	struct sk_buff *skb;
>-	struct ethhdr *ethh;
> 	struct udphdr *uh;
> 	int data_len;
> 	int ret;
>@@ -61,7 +60,7 @@ static int __init test_blackholedev_init(void)
> 	ip6h->saddr = in6addr_loopback;
> 	ip6h->daddr = in6addr_loopback;
> 	/* Ether */
>-	ethh = (struct ethhdr *)skb_push(skb, sizeof(struct ethhdr));
>+	skb_push(skb, sizeof(struct ethhdr));
> 	skb_set_mac_header(skb, 0);
> 
> 	skb->protocol = htons(ETH_P_IPV6);
>-- 
>2.39.3
>
>