linux-kernel - Re: [PATCH v10 16/29] KVM: selftests: Test Intel PMU architectural events on gp counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50507559-ffb6-4340-a3ac-c0fdba3c9ab8@linux.intel.com>
Date: Thu, 1 Feb 2024 09:51:41 +0800
From: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Kan Liang <kan.liang@...ux.intel.com>,
 Jim Mattson <jmattson@...gle.com>, Jinrong Liang <cloudliang@...cent.com>,
 Aaron Lewis <aaronlewis@...gle.com>, Like Xu <likexu@...cent.com>
Subject: Re: [PATCH v10 16/29] KVM: selftests: Test Intel PMU architectural
 events on gp counters

On 1/31/2024 11:31 PM, Sean Christopherson wrote:
> On Wed, Jan 31, 2024, Dapeng Mi wrote:
>> BTW, I have a patch series to do the bug fixes and improvements for
>> kvm-unit-tests/pmu test. (some improvement ideas come from this patchset.)
>>
>> https://lore.kernel.org/kvm/20240103031409.2504051-1-dapeng1.mi@linux.intel.com/
>>
>> Could you please kindly review them? Thanks.
> Unfortunately, that's probably not going to happen anytime soon.  I am overloaded
> with KVM/kernel reviews as it is, so I don't expect to have cycles for KUT reviews
> in the near future.
>
> And for PMU tests in particular, I really want to get selftests to the point where
> the PMU selftests are a superset of the PMU KUT tests so that we can drop the KUT
> versions.  In short, reviewing PMU KUT changes is very far down my todo list.

Yeah, It's good and convenient that we can have one-stop test suite to 
verify the PMU functions, so we don't need to verify the PMU functions 
each time with KUT/PMU test and selftest/pmu test independently.

While it looks KUT/PMU test is still broadly used to verify KVM PMU 
features by many users, and the patchset mainly fixes several KUT/PMU 
bugs which would cause false alarms. If these bugs are not fixed, they 
would mislead the users.

Yeah, patch reviewing takes much time and effort, thanks a lot for you 
reviewing our patches in the past, and hope you can review this patchset 
when you are free.