linux-kernel - RE: [PATCH v2] x86/boot: Add a message about ignored early NMIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 01 Feb 2024 09:22:09 -0800
From: "H. Peter Anvin" <hpa@...or.com>
To: NOMURA JUNICHI(野村　淳一) <junichi.nomura@....com>,
        Borislav Petkov <bp@...en8.de>
CC: "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "ardb@...nel.org" <ardb@...nel.org>,
        "david@...hat.com" <david@...hat.com>,
        "nikunj@....com" <nikunj@....com>,
        "thomas.lendacky@....com" <thomas.lendacky@....com>,
        "debarbos@...hat.com" <debarbos@...hat.com>,
        "jlelli@...hat.com" <jlelli@...hat.com>,
        "lgoncalv@...hat.com" <lgoncalv@...hat.com>,
        "dzickus@...hat.com" <dzickus@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] x86/boot: Add a message about ignored early NMIs

On January 25, 2024 6:15:15 PM PST, "NOMURA JUNICHI(野村　淳一)" <junichi.nomura@....com> wrote:
>> From: H. Peter Anvin <hpa@...or.com>
>> On 1/24/24 03:44, NOMURA JUNICHI(野村 淳一) wrote:
>> >> From: Borislav Petkov <bp@...en8.de>
>> >> On Mon, Jan 15, 2024 at 08:57:45AM +0000, NOMURA JUNICHI(野村 淳一) wrote:
>> >>> +	if (spurious_nmi_count) {
>> >>> +		error_putstr("Spurious early NMI ignored. Number of NMIs: 0x");
>> >>> +		error_puthex(spurious_nmi_count);
>> >>> +		error_putstr("\n");
>> >>
>> >> Uff, that's just silly:
>> >>
>> >> Spurious early NMIs ignored: 0x0000000000000017
>> >>
>> >> Would you like to add a error_putnum() or so in a prepatch which would
>> >> make this output
>> >>
>> >> Spurious early NMIs ignored: 23.
>> >>
>> >> ?
>> >>
>> >> So that it is human readable and doesn't make me wonder what that hex
>> >> value is supposed to mean?
>> >
>> > Yes, it would be nicer to print that way.  I used the existing error_puthex() just
>> > to keep the patch minimal.  I will try to add error_putnum().
>> >
>> >> Btw, please use this version when sending next time:
>> 
>> Here is a *completely* untested patch for you...
>
>Ah, I was preparing decimal only version but yours is much better.
>I tested and it just works.
>
>I would like to use yours as a prepatch.  May I have your signed-off-by?
>
>--
>Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.

Signed-off-by: H. Peter Anvin (Intel) <hpa@...or.com>