linux-kernel - Re: [PATCH v1 03/18] thermal: Directly use thermal_zone_platform_params for thermal_zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 1 Feb 2024 20:42:52 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: daniel.lezcano@...aro.org, miquel.raynal@...tlin.com, rafael@...nel.org, 
	rui.zhang@...el.com, lukasz.luba@....com, support.opensource@...semi.com, 
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, 
	festevam@...il.com, linux-imx@....com, andersson@...nel.org, 
	konrad.dybcio@...aro.org, amitk@...nel.org, thara.gopinath@...il.com, 
	niklas.soderlund@...natech.se, srinivas.pandruvada@...ux.intel.com, 
	baolin.wang@...ux.alibaba.com, u.kleine-koenig@...gutronix.de, 
	hayashi.kunihiko@...ionext.com, d-gole@...com, linus.walleij@...aro.org, 
	DLG-Adam.Ward.opensource@...renesas.com, error27@...il.com, heiko@...ech.de, 
	hdegoede@...hat.com, jernej.skrabec@...il.com, f.fainelli@...il.com, 
	bchihi@...libre.com, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH v1 03/18] thermal: Directly use thermal_zone_platform_params
 for thermal_zone_device

On Tue, Jan 30, 2024 at 12:13 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> Remove all duplicate members from thermal_zone_device and directly
> use the corresponding ones from struct thermal_zone_platform_params.

I totally disagree with this approach.

It does make sense to store these things in a tz directly.

1. devdata allows the caller of the thermal zone to get to their own
information on it conveniently.  This patch makes it harder.
2. It makes sense to copy type into tz to allow the zone creator to
free the string (should they want to do that).
3. It would make sense to copy the contents of the trips[] table to tz
to allow the zone creator to free their initial table.  This doesn't
happen today, but it is in the works and your patch goes against this.
4. It makes sense to copy num_trips directly to tz, because it is
closely related to trips[].
5. It makes sense to copy ops directly into tz, because this will
allow zone creators to use const ops for zone registration.  Again,
this doesn't happen today, but it is in the works and this patch goes
against this.

As far as I'm concerned, this one is a total no-go.

Thanks!