linux-kernel - Re: [PATCH 2/4] arm64: dts: sun50i-a64-pinephone: Retain leds state in suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10409647.nUPlyArG6x@jernej-laptop>
Date: Thu, 01 Feb 2024 20:54:12 +0100
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: Aren <aren@...cevolution.org>
Cc: linux-kernel@...r.kernel.org, Miles Alan <m@...esalan.com>,
 Ondrej Jirman <megi@....cz>, Chen-Yu Tsai <wens@...e.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Rob Herring <robh+dt@...nel.org>, Samuel Holland <samuel@...lland.org>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev
Subject:
 Re: [PATCH 2/4] arm64: dts: sun50i-a64-pinephone: Retain leds state in
 suspend

Dne četrtek, 01. februar 2024 ob 02:36:46 CET je Aren napisal(a):
> On Tue, Jan 30, 2024 at 08:06:24PM +0100, Jernej Škrabec wrote:
> > Dne nedelja, 28. januar 2024 ob 21:45:08 CET je Aren Moynihan napisal(a):
> > > From: Miles Alan <m@...esalan.com>
> > > 
> > > Allows user to set a led before entering suspend to know that
> > > the phone is still on (or could be used for notifications etc.)
> > > 
> > > Signed-off-by: Miles Alan <m@...esalan.com>
> > > Signed-off-by: Ondrej Jirman <megi@....cz>
> > > Signed-off-by: Aren Moynihan <aren@...cevolution.org>
> > 
> > Where is patch 1 and possibly cover letter? Please resend with all patches.
> 
> Oops, sorry about that, I'm still getting used to get_maintainer.pl.
> I'll resend this properly when I have time this weekend, until then the
> patch you missed is available at
> https://lore.kernel.org/lkml/20240128204740.2355092-1-aren@peacevolution.org/

When sending patch series it's customary to send all patches to all
maintainers and mailing lists (to have a context). In case of large patch
series, you can send only selected patches to each maintainer and mailing
lists, but then send cover letter to all involved and explain general idea
behind the series.

Best regards,
Jernej

> 
> > However, this particular patch is:
> > Reviewed-by: Jernej Skrabec <jernej.skrabec@...il.com>
> 
> Thanks
>  - Aren
> 
> > Best regards,
> > Jernej
> > 
> > > ---
> > > 
> > >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > > index 87847116ab6d..ad2476ee01e4 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > > @@ -43,18 +43,21 @@ led-0 {
> > >  			function = LED_FUNCTION_INDICATOR;
> > >  			color = <LED_COLOR_ID_BLUE>;
> > >  			gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */
> > > +			retain-state-suspended;
> > >  		};
> > >  
> > >  		led-1 {
> > >  			function = LED_FUNCTION_INDICATOR;
> > >  			color = <LED_COLOR_ID_GREEN>;
> > >  			gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */
> > > +			retain-state-suspended;
> > >  		};
> > >  
> > >  		led-2 {
> > >  			function = LED_FUNCTION_INDICATOR;
> > >  			color = <LED_COLOR_ID_RED>;
> > >  			gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */
> > > +			retain-state-suspended;
> > >  		};
> > >  	};
> > >  
> > > 
> > 
> > 
> > 
> > 
>