linux-kernel - Re: [PATCH v2] fscrypt: to make sure the inode->i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240201024828.GA1526@sol.localdomain>
Date: Wed, 31 Jan 2024 18:48:28 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: xiubli@...hat.com
Cc: linux-fscrypt@...r.kernel.org, tytso@....edu, jaegeuk@...nel.org,
	linux-kernel@...r.kernel.org, idryomov@...il.com,
	ceph-devel@...r.kernel.org, jlayton@...nel.org, vshankar@...hat.com,
	mchangir@...hat.com
Subject: Re: [PATCH v2] fscrypt: to make sure the inode->i_blkbits is
 correctly set

On Thu, Feb 01, 2024 at 08:35:25AM +0800, xiubli@...hat.com wrote:
> From: Xiubo Li <xiubli@...hat.com>
> 
> The inode->i_blkbits should be already set before calling
> fscrypt_get_encryption_info() and it will use this to setup the
> ci_data_unit_bits later.
> 
> URL: https://tracker.ceph.com/issues/64035
> Signed-off-by: Xiubo Li <xiubli@...hat.com>

Thanks, applied.  I adjusted the commit message to make it clear what the patch
actually does:

commit 5befc19caec93f0088595b4d28baf10658c27a0f
Author: Xiubo Li <xiubli@...hat.com>
Date:   Thu Feb 1 08:35:25 2024 +0800

    fscrypt: explicitly require that inode->i_blkbits be set

    Document that fscrypt_prepare_new_inode() requires inode->i_blkbits to
    be set, and make it WARN if it's not.  This would have made the CephFS
    bug https://tracker.ceph.com/issues/64035 a bit easier to debug.

    Signed-off-by: Xiubo Li <xiubli@...hat.com>
    Link: https://lore.kernel.org/r/20240201003525.1788594-1-xiubli@redhat.com
    Signed-off-by: Eric Biggers <ebiggers@...gle.com>