linux-kernel - Re: [GIT PULL] perf tools fixes for v6.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbwSJAayut8nXSXw@kernel.org>
Date: Thu, 1 Feb 2024 18:50:28 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Ingo Molnar <mingo@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Clark Williams <williams@...hat.com>,
	Kate Carcia <kcarcia@...hat.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org, James Clark <james.clark@....com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Sun Haiyong <sunhaiyong@...ngson.cn>,
	Thomas Richter <tmricht@...ux.ibm.com>,
	Yanteng Si <siyanteng@...ngson.cn>,
	Yicong Yang <yangyicong@...ilicon.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [GIT PULL] perf tools fixes for v6.8

Em Thu, Feb 01, 2024 at 06:26:37PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Feb 01, 2024 at 01:21:16PM -0800, Linus Torvalds escreveu:
> > On Thu, 1 Feb 2024 at 13:14, Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > > I should've known better and not send the noisy JSON changes at this
> > > point in time.
> > 
> > Arnaldo, it's not the JSON changes in the history.
> > 
> > It's the absolute garbage in the *tag* itself. It's crazy. Do this"
> > 
> >    git fetch   git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git
> > perf-tools-fixes-for-v6.8-1-2024-02-01
> > 
> >    git cat-file tag FETCH_HEAD
> > 
> > and see complete and utter garbage in the tag contents.
> > 
> > Note: that is not a change *made* by the tag. It's literally just
> > garbage content in the tag *message* itself.
> > 
> > You have something *seriously* wrong with your scripting or tag
> > creation workflow.
> 
> Ok, I'll check, as I said I switched machines, I must've screwed up
> something.

	I created that tag, then realized I made a mistake, did a "git
show that-tag > /tmp/foo" to save the cover letter, then when recreating
e signed tag used the contents of that temp file, but forgot to remove
the end that contained the previous HEAD, d0h.

	I fixed the tag and force pushed it now, I looked at:

https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git/tag/?h=perf-tools-fixes-for-v6.8-1-2024-02-01

	And it has what was intended, hopefully no craziness now...

	Double checking:

[acme@...co linux]$ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git perf-tools-fixes-for-v6.8-1-2024-02-01
remote: Enumerating objects: 2084, done.
remote: Counting objects: 100% (1075/1075), done.
remote: Compressing objects: 100% (20/20), done.
remote: Total 2084 (delta 1055), reused 1071 (delta 1053), pack-reused 1009
Receiving objects: 100% (2084/2084), 1.18 MiB | 1.15 MiB/s, done.
Resolving deltas: 100% (1589/1589), completed with 551 local objects.
>From git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools
 * tag                                 perf-tools-fixes-for-v6.8-1-2024-02-01 -> FETCH_HEAD
[acme@...co linux]$ 
[acme@...co linux]$ git cat-file tag FETCH_HEAD | tail
  - Also, without tooling effects: asm-generic/unaligned.h, mount.h, fcntl.h, kvm headers.

Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQR2GiIUctdOfX2qHhGyPKLppCJ+JwUCZbwOmQAKCRCyPKLppCJ+
J/TkAP92DD1ZKmc9WzlJ8vpbz+nXwvMIDTRSSBnvYPiDNSL6xAEAkX92qWUQ35RS
faz2v593RZ4VfthcAEl5P6FXEhHhfAc=
=pDc1
-----END PGP SIGNATURE-----
[acme@...co linux]$ 

- Arnaldo