linux-kernel - Re: [patch V2 04/22] x86/apic: Get rid of get_physical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 1 Feb 2024 14:24:28 -0800
From: Sohil Mehta <sohil.mehta@...el.com>
To: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>
CC: <x86@...nel.org>, Tom Lendacky <thomas.lendacky@....com>, Andrew Cooper
	<andrew.cooper3@...rix.com>, Arjan van de Ven <arjan@...ux.intel.com>, "Huang
 Rui" <ray.huang@....com>, Juergen Gross <jgross@...e.com>, Dimitri Sivanich
	<dimitri.sivanich@....com>, K Prateek Nayak <kprateek.nayak@....com>, "Kan
 Liang" <kan.liang@...ux.intel.com>, Zhang Rui <rui.zhang@...el.com>, "Paul E.
 McKenney" <paulmck@...nel.org>, Feng Tang <feng.tang@...el.com>, "Andy
 Shevchenko" <andy@...radead.org>, Michael Kelley <mhklinux@...look.com>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>, Andy Shevchenko
	<andy.shevchenko@...il.com>, Wei Liu <wei.liu@...nel.org>
Subject: Re: [patch V2 04/22] x86/apic: Get rid of get_physical_broadcast()

On 1/23/2024 5:10 AM, Thomas Gleixner wrote:

> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c

> @@ -1499,15 +1498,14 @@ static void __init setup_ioapic_ids_from
>  		 */
>  		if (apic->check_apicid_used(&phys_id_present_map,
>  					    mpc_ioapic_id(ioapic_idx))) {
> -			printk(KERN_ERR "BIOS bug, IO-APIC#%d ID %d is already used!...\n",
> +			pr_err(FW_BUG "IO-APIC#%d ID %d is already used!...\n",
>  				ioapic_idx, mpc_ioapic_id(ioapic_idx));

The second line could be aligned to match the open parenthesis.