linux-kernel - Re: [patch v2 25/30] x86/cpu/topology: Use topology logical mapping mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15d8e520-c129-4b09-9a25-ecee5da36ca6@intel.com>
Date: Thu, 1 Feb 2024 14:31:21 -0800
From: Sohil Mehta <sohil.mehta@...el.com>
To: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>
CC: <x86@...nel.org>, Tom Lendacky <thomas.lendacky@....com>, Andrew Cooper
	<andrew.cooper3@...rix.com>, Arjan van de Ven <arjan@...ux.intel.com>, "Huang
 Rui" <ray.huang@....com>, Juergen Gross <jgross@...e.com>, Dimitri Sivanich
	<dimitri.sivanich@....com>, K Prateek Nayak <kprateek.nayak@....com>, "Kan
 Liang" <kan.liang@...ux.intel.com>, Zhang Rui <rui.zhang@...el.com>, "Paul E.
 McKenney" <paulmck@...nel.org>, Feng Tang <feng.tang@...el.com>, "Andy
 Shevchenko" <andy@...radead.org>, Michael Kelley <mhklinux@...look.com>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [patch v2 25/30] x86/cpu/topology: Use topology logical mapping
 mechanism

On 1/23/2024 5:11 AM, Thomas Gleixner wrote:

> --- a/arch/x86/include/asm/topology.h
> +++ b/arch/x86/include/asm/topology.h
> @@ -172,6 +172,13 @@ static inline int topology_get_logical_i
>  #define topology_core_cpumask(cpu)		(per_cpu(cpu_core_map, cpu))
>  #define topology_sibling_cpumask(cpu)		(per_cpu(cpu_sibling_map, cpu))
>  
> +

This additional new line can be avoided.

> +static inline int topology_phys_to_logical_pkg(unsigned int pkg)
> +{
> +	return topology_get_logical_id(pkg << x86_topo_system.dom_shifts[TOPO_PKG_DOMAIN],
> +				       TOPO_PKG_DOMAIN);
> +}
> +