[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240201230351.GA1900918-robh@kernel.org>
Date: Thu, 1 Feb 2024 17:03:51 -0600
From: Rob Herring <robh@...nel.org>
To: Andrew Davis <afd@...com>
Cc: Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
Santosh Shilimkar <ssantosh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Sebastian Reichel <sre@...nel.org>,
Vignesh Raghavendra <vigneshr@...com>,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 02/12] dt-bindings: arm: keystone: ti-sci: Add
reboot-controller child node
On Wed, Jan 31, 2024 at 04:19:47PM -0600, Andrew Davis wrote:
> The TI-SCI firmware supports rebooting the system in addition to the
> functions already listed here, document child node for the same.
>
> Signed-off-by: Andrew Davis <afd@...com>
> ---
> .../devicetree/bindings/arm/keystone/ti,sci.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index c24ad0968f3ef..e392175b33c74 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -83,6 +83,10 @@ properties:
> type: object
> $ref: /schemas/reset/ti,sci-reset.yaml#
>
> + reboot-controller:
> + type: object
> + $ref: /schemas/power/reset/ti,sci-reboot.yaml#
Don't need a ref just for a single property.
But then why do we need a node here at all? Can't you assume reboot
support for TI-SCI firmware (i.e. based on the parent node). Then you
don't need a DT update to add the feature.
Rob
Powered by blists - more mailing lists