linux-kernel - Re: [PATCH 4/4] ACPI: RISCV: Enable ACPI based NUMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6abae3ef-fc91-4283-b6a3-20810ececfe8@app.fastmail.com>
Date: Thu, 01 Feb 2024 06:52:10 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Haibo Xu" <xiaobo55x@...il.com>
Cc: "Haibo Xu" <haibo1.xu@...el.com>,
 "Alison Schofield" <alison.schofield@...el.com>,
 "Rafael J . Wysocki" <rafael@...nel.org>,
 "Dave Hansen" <dave.hansen@...ux.intel.com>,
 linux-kernel@...r.kernel.org,
 "Conor.Dooley" <conor.dooley@...rochip.com>, guoren <guoren@...nel.org>,
 "Jisheng Zhang" <jszhang@...nel.org>,
 "James Morse" <james.morse@....com>, linux-riscv@...ts.infradead.org,
 "Ard Biesheuvel" <ardb@...nel.org>, "Baoquan He" <bhe@...hat.com>,
 acpica-devel@...ts.linux.dev, "Robert Moore" <robert.moore@...el.com>,
 linux-acpi@...r.kernel.org, "Sami Tolvanen" <samitolvanen@...gle.com>,
 "Greentime Hu" <greentime.hu@...ive.com>, "Len Brown" <lenb@...nel.org>,
 "Albert Ou" <aou@...s.berkeley.edu>,
 "Alexandre Ghiti" <alexghiti@...osinc.com>,
 "Dan Williams" <dan.j.williams@...el.com>,
 "Chen Jiahao" <chenjiahao16@...wei.com>,
 "Yuntao Wang" <ytcoode@...il.com>,
 "Paul Walmsley" <paul.walmsley@...ive.com>,
 Clément Léger <cleger@...osinc.com>,
 "Anup Patel" <apatel@...tanamicro.com>,
 "Tony Luck" <tony.luck@...el.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Russell King" <rmk+kernel@...linux.org.uk>,
 "Samuel Holland" <samuel.holland@...ive.com>,
 "Evan Green" <evan@...osinc.com>, "Palmer Dabbelt" <palmer@...belt.com>,
 "Andrew Jones" <ajones@...tanamicro.com>
Subject: Re: [PATCH 4/4] ACPI: RISCV: Enable ACPI based NUMA

On Thu, Feb 1, 2024, at 03:58, Haibo Xu wrote:
> On Wed, Jan 31, 2024 at 5:33 PM Arnd Bergmann <arnd@...db.de> wrote:
>>
>> On Wed, Jan 31, 2024, at 03:32, Haibo Xu wrote:
>> > diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig
>> > index 849c2bd820b9..525297c44250 100644
>> > --- a/drivers/acpi/numa/Kconfig
>> > +++ b/drivers/acpi/numa/Kconfig
>> > @@ -2,7 +2,7 @@
>> >  config ACPI_NUMA
>> >       bool "NUMA support"
>> >       depends on NUMA
>> > -     depends on (X86 || ARM64 || LOONGARCH)
>> > +     depends on (X86 || ARM64 || LOONGARCH || RISCV)
>>
>> The dependency is no longer needed now since these are
>> the four architectures that support ACPI now that IA64
>> is gone.
>>
>> All of them also 'select ACPI_NUMA' by default, though on
>> x86 this can still be disabled by manually turning off
>> CONFIG_X86_64_ACPI_NUMA. I suspect we don't actually ever
>> want to turn it off on x86 either, so I guess the Kconfig
>> option can just be removed entirely.
>>
>
> Good catch! Will revert the change in the next version.
>
> To remove the dependency entirely, I think we need a separate patch for it.
> What's your opinion?

Agreed, that last bit would need to be acked by the x86
maintainers then, as it only affects them in practice.

     Arnd