lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d2c0c5dd-e1a2-4607-9177-f3855cb5601e@linaro.org>
Date: Thu, 1 Feb 2024 09:40:58 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andrei Simion <andrei.simion@...rochip.com>,
 krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org, conor+dt@...nel.org,
 claudiu.beznea@...on.dev, lgirdwood@...il.com, broonie@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v3] regulator: dt-bindings: microchip,mcp16502: convert to
 YAML

On 31/01/2024 14:07, Andrei Simion wrote:
> Convert devicetree binding mcp16502-regulator.txt to YAML format.
> 
> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>
> ---
> Changes v2 -> v3:
> - keep one line of regulators description
> - add additionalProperties: false for regulators
> - "description:" at the end for each properties
> 
> Changes v1 -> v2:
> - reverse subject prefixes
> - line break after file "description:"
> - drop description for reg
> - drop regulator-name
> - add regulator-initial-mode
> - unevaluatedProperties just after $ref: regulator.yaml#
> - additionalProperties  just before "required"

I missed it before, why did you move it? Previous placement was what we
expect. I did not comment about it.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ