lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 01 Feb 2024 11:22:16 +0200
From: Jani Nikula <jani.nikula@...el.com>
To: Paz Zcharya <pazz@...omium.org>, Jouni Högander
 <jouni.hogander@...el.com>, Luca Coelho <luciano.coelho@...el.com>
Cc: Subrata Banik <subratabanik@...gle.com>, Manasi Navare
 <navaremanasi@...omium.org>, Drew Davenport <ddavenport@...omium.org>,
 Sean Paul <seanpaul@...omium.org>, Marcin Wojtas <mwojtas@...omium.org>,
 khaled.almahallawy@...el.com, intel-gfx@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, Paz Zcharya
 <pazz@...omium.org>
Subject: Re: [PATCH] drm/i915/display: Include debugfs.h in
 intel_display_debugfs_params.c

On Wed, 31 Jan 2024, Paz Zcharya <pazz@...omium.org> wrote:
> Commit 8015bee0bfec ("drm/i915/display: Add framework to add parameters
> specific to display") added the file intel_display_debugfs_params.c,
> which calls the functions "debugfs_create_{bool, ulong, str}" -- all of
> which are defined in <linux/debugfs.h>. The missing inclusion of this
> header file is breaking the ChromeOS build -- add an explicit include
> to fix that.
>

Thanks for the patch, apparently in our configs some paths lead to
debugfs.h. Just goes on to show how interdependent the kernel headers
are.

Out of curiousity, what value do you have for CONFIG_DEBUG_FS kconfig?

Fixes: 8015bee0bfec ("drm/i915/display: Add framework to add parameters specific to display")
Reviewed-by: Jani Nikula <jani.nikula@...el.com>

BR,
Jani.


> Signed-off-by: Paz Zcharya <pazz@...omium.org>
> ---
>  drivers/gpu/drm/i915/display/intel_display_debugfs_params.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs_params.c b/drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
> index b7e68eb62452..f35718748555 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
> @@ -3,6 +3,7 @@
>   * Copyright © 2023 Intel Corporation
>   */
>  
> +#include <linux/debugfs.h>
>  #include <linux/kernel.h>
>  
>  #include <drm/drm_drv.h>

-- 
Jani Nikula, Intel

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ