linux-kernel - Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <VI1PR04MB50055CD3C608C5A0407B113BE8432@VI1PR04MB5005.eurprd04.prod.outlook.com>
Date: Thu, 1 Feb 2024 09:58:13 +0000
From: Carlos Song <carlos.song@....com>
To: Francesco Dolcini <francesco@...cini.it>
CC: "broonie@...nel.org" <broonie@...nel.org>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, dl-linux-imx
	<linux-imx@....com>, "benjamin@...ler.one" <benjamin@...ler.one>,
	"stefanmoring@...il.com" <stefanmoring@...il.com>,
	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU
 mode

> -----Original Message-----
> From: Francesco Dolcini <francesco@...cini.it>
> Sent: Thursday, February 1, 2024 4:52 PM
> To: Carlos Song <carlos.song@....com>
> Cc: Francesco Dolcini <francesco@...cini.it>; broonie@...nel.org;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> dl-linux-imx <linux-imx@....com>; benjamin@...ler.one;
> stefanmoring@...il.com; linux-spi@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: [EXT] Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU
> mode
> 
> Caution: This is an external email. Please take care when clicking links or opening
> attachments. When in doubt, report the message using the 'Report this email'
> button
> 
> 
> On Thu, Feb 01, 2024 at 02:02:36AM +0000, Carlos Song wrote:
> > > From: Francesco Dolcini <francesco@...cini.it> Add #include
> > > <linux/bits.h> given you are using BITS_PER_BYTE
> > >
> > I found that <linux/property.h> has been included in spi-imx.c driver.
> > And <linux/bits.h> has been included in <linux/property.h>.
> > So I didn't add the "#include <linux/bits.h>" on purpose.
> 
> I think you should be explicit and include this header.
> Code get refactored all the time and you can prevent issues this way.
> 
Hi，
Thank you! This is acceptable, I will include <linux/bits.h> explicitly and send V3.

BR
Carlos

> Francesco
>