linux-kernel - Re: [PATCH 1/2] ata: ahci: Add force LPM policy quirk for ASUS B1400CEAE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Zbtz2G+OHvm/WB4b@x1-carbon>
Date: Thu, 1 Feb 2024 11:35:04 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Виталий Соломонов <solomonov.v@...il.com>
Cc: Daniel Drake <drake@...lessos.org>, Jian-Hong Pan <jhp@...lessos.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	David Box <david.e.box@...ux.intel.com>,
	Damien Le Moal <dlemoal@...nel.org>,
	Nirmal Patel <nirmal.patel@...ux.intel.com>,
	Jonathan Derrick <jonathan.derrick@...ux.dev>,
	linux-ide@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux@...lessos.org
Subject: Re: [PATCH 1/2] ata: ahci: Add force LPM policy quirk for ASUS
 B1400CEAE

On Thu, Feb 01, 2024 at 06:50:53AM +0300, Виталий Соломонов wrote:
> Hello Daniel, Niklas
> 
> I assume that both of these logs are from the same kernel binary.
> > Does this kernel binary have the Tiger Lake LPM enablement patch included?
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/?id=104ff59af73aba524e57ae0fef70121643ff270e
> 
> Yes, it's the same kernel binary with applied patch.
> 
> 
> 
> > Could you please try to set:
> > CONFIG_SATA_MOBILE_LPM_POLICY=3
> > and enable VMD again, and see if that makes you able to detect the SATA
> > drive even with VMD enabled.
> >
>  With this policy settings my laptop was able to mount lvm volumes (/ and
> /boot) on SSD (/dev/nvme), and stuck on mounting HDD volumes (/home)
> dmesg: https://bugzilla.kernel.org/attachment.cgi?id=305804
> journalctl: https://bugzilla.kernel.org/attachment.cgi?id=305805

Just to clarify, in this latest log VMD_on_LPM_3_dmesg:
[    0.957793] ahci 10000:e0:17.0: AHCI 0001.0301 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[    0.957796] ahci 10000:e0:17.0: flags: 64bit ncq sntf pm clo only pio slum part deso sadm sds 
[    0.957982] ata1: SATA max UDMA/133 abar m2048@...2102000 port 0x82102100 irq 142 lpm-pol 4
[    1.271254] ata1: SATA link down (SStatus 4 SControl 300)

We still don't get any link up, so LPM policy == 3 did no difference.

I guess someone at Intel needs to debug why we don't get a link up with
VMD enabled, since AFAICT, having VMD enabled is like adding an extra HW layer:
libata -> Intel VMD -> Intel AHCI controller
instead of the normal
libata -> Intel AHCI controller

Since it works when talking to the AHCI controller directly, the question
is if it is VMD not following the spec, or if it libata that is not following
the spec (and we are just lucky that it works when talking to the Intel AHCI
controller directly).


Kind regards,
Niklas