linux-kernel - Re: [PATCH] ALSA: usb-audio: retry clock validate when it takes some times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6872e9ea993633dff4e248f01cafd1ac32651355.camel@tsoy.me>
Date: Thu, 01 Feb 2024 13:36:11 +0300
From: Alexander Tsoy <alexander@...y.me>
To: vincenttew <vincenttew@...gle.com>, perex@...ex.cz, tiwai@...e.com, 
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH] ALSA: usb-audio: retry clock validate when it takes
 some times

В Чт, 01/02/2024 в 15:06 +0800, vincenttew пишет:
> Behringer UMC202HD and UMC404HD take some times to validate the clock
> source. To prevent more DAC have the same delay which return the
> false
> in the first time, remove the USB id check to have a chance to retry
> the
> clock validate.
> 
> Signed-off-by: vincenttew <vincenttew@...gle.com>

Thank you for the patch! My thought about this change:
- Retrying clock source validation probably make sense only in the case
of Internal clock. But I'm not sure.
- If we want to make this a standard driver behaviour, then the code
needs to be moved out of the quirk function IMO.