linux-kernel - Re: [PATCH v4 1/2] printk: Add function to dump printk buffer directly to consoles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sf2co23t.fsf@jogness.linutronix.de>
Date: Thu, 01 Feb 2024 12:34:22 +0106
From: John Ogness <john.ogness@...utronix.de>
To: Sreenath Vijayan <sreenath.vijayan@...y.com>, corbet@....net,
 gregkh@...uxfoundation.org, jirislaby@...nel.org, pmladek@...e.com
Cc: rdunlap@...radead.org, rostedt@...dmis.org, senozhatsky@...omium.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, taichi.shimoyashiki@...y.com,
 daniel.palmer@...y.com, anandakumar.balasubramaniam@...y.com,
 sreenath.vijayan@...y.com
Subject: Re: [PATCH v4 1/2] printk: Add function to dump printk buffer
 directly to consoles

On 2024-02-01, Sreenath Vijayan <sreenath.vijayan@...y.com> wrote:
> It is useful to be able to dump the printk buffer directly to
> consoles in some situations so as to not flood the buffer.
> To do this, we reuse the CONSOLE_REPLAY_ALL mode code in
> console_flush_on_panic() by moving the code to a helper function
> console_rewind_all(). This is done because console_flush_on_panic()
> sets console_may_schedule to 0 but this should not be done in our
> case. Then console_rewind_all() is called from the new function
> dump_printk_buffer() with console lock held to set the console
> sequence number to oldest record in the buffer for all consoles.
> Releasing the console lock will flush the contents of printk buffer
> to the consoles.
>
> Suggested-by: John Ogness <john.ogness@...utronix.de>
> Signed-off-by: Sreenath Vijayan <sreenath.vijayan@...y.com>
> Signed-off-by: Shimoyashiki Taichi <taichi.shimoyashiki@...y.com>

Reviewed-by: John Ogness <john.ogness@...utronix.de>