linux-kernel - Re: [PATCH] samples: mei: remove unused parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4c6a0a1-e02b-4668-b3b3-0ba04fa079a6@gmail.com>
Date: Thu, 1 Feb 2024 19:58:07 +0800
From: kuiliang Shi <seakeel@...il.com>
To: alexs@...nel.org, Tomas Winkler <tomas.winkler@...el.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] samples: mei: remove unused parameter

ping

On 1/19/24 12:00 PM, alexs@...nel.org wrote:
> From: Alex Shi <alexs@...nel.org>
> 
> The timeout parameter isn't used in func mei_send_msg(), better to
> remove it.
> 
> Signed-off-by: Alex Shi <alexs@...nel.org>
> To: linux-kernel@...r.kernel.org
> To: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  samples/mei/mei-amt-version.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/samples/mei/mei-amt-version.c b/samples/mei/mei-amt-version.c
> index 867debd3b912..bf14d8a819b9 100644
> --- a/samples/mei/mei-amt-version.c
> +++ b/samples/mei/mei-amt-version.c
> @@ -195,8 +195,7 @@ static ssize_t mei_recv_msg(struct mei *me, unsigned char *buffer,
>  	return rc;
>  }
>  
> -static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer,
> -			ssize_t len, unsigned long timeout)
> +static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer, ssize_t len)
>  {
>  	ssize_t written;
>  	ssize_t rc;
> @@ -391,8 +390,7 @@ static uint32_t amt_host_if_call(struct amt_host_if *acmd,
>  	memset(*read_buf, 0, in_buf_sz);
>  	msg_hdr = (struct amt_host_if_resp_header *)*read_buf;
>  
> -	written = mei_send_msg(&acmd->mei_cl,
> -				command, command_sz, acmd->send_timeout);
> +	written = mei_send_msg(&acmd->mei_cl, command, command_sz);
>  	if (written != command_sz)
>  		return AMT_STATUS_INTERNAL_ERROR;
>