linux-kernel - Re: [PATCH] clk: keystone: sci-clk: check devm_kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 1 Feb 2024 15:02:52 +0300
From: Александра Дюпина
 <adiupina@...ralinux.ru>
To: Nishanth Menon <nm@...com>
Cc: Tero Kristo <kristo@...nel.org>, Santosh Shilimkar <ssantosh@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH] clk: keystone: sci-clk: check devm_kmalloc_array() return
 value

just a friendly reminder

10/01/24 16:46, Alexandra Diupina:
> devm_kmalloc_array() may return NULL, so
> check return value to avoid null pointer
> dereferencing
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 3c13933c6033 ("clk: keystone: sci-clk: add support for dynamically probing clocks")
> Signed-off-by: Alexandra Diupina <adiupina@...ralinux.ru>
> ---
>   drivers/clk/keystone/sci-clk.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/keystone/sci-clk.c b/drivers/clk/keystone/sci-clk.c
> index 35fe197dd303..a2fa24e4f88a 100644
> --- a/drivers/clk/keystone/sci-clk.c
> +++ b/drivers/clk/keystone/sci-clk.c
> @@ -459,6 +459,9 @@ static int ti_sci_scan_clocks_from_fw(struct sci_clk_provider *provider)
>   			tmp_clks = devm_kmalloc_array(dev, max_clks + 64,
>   						      sizeof(sci_clk),
>   						      GFP_KERNEL);
> +			if (!tmp_clks)
> +				return -ENOMEM;
> +
>   			memcpy(tmp_clks, clks, max_clks * sizeof(sci_clk));
>   			if (max_clks)
>   				devm_kfree(dev, clks);