linux-kernel - Re: [PATCH] ALSA: core: Fix dependencies for SND_CORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eddwz667.wl-tiwai@suse.de>
Date: Thu, 01 Feb 2024 14:05:04 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Ivan Orlov <ivan.orlov0322@...il.com>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST

On Thu, 01 Feb 2024 10:46:04 +0100,
Ivan Orlov wrote:
> 
> Add the CONFIG_SND_PCM dependency for CONFIG_SND_CORE_TEST config entry
> as the test uses symbols from 'pcm_misc.c'.
> 
> Signed-off-by: Ivan Orlov <ivan.orlov0322@...il.com>

It should rather select instead of depends-on.  User can't enable
CONFIG_SND_PCM explicitly, but it's selected by the top-level
drivers.

Also, please add Fixes tag.  It's a clear regression fix.


thanks,

Takashi