linux-kernel - Re: [PATCH] atm: idt77252: fix a memleak in open_card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbucvTJswt41cpcI@nanopsycho>
Date: Thu, 1 Feb 2024 14:29:33 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Zhipeng Lu <alexious@....edu.cn>
Cc: Chas Williams <3chas3@...il.com>,
	linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: idt77252: fix a memleak in open_card_ubr0

Thu, Feb 01, 2024 at 01:41:05PM CET, alexious@....edu.cn wrote:
>When alloc_scq fails, card->vcs[0] (i.e. vc) should be freed. Otherwise,
>in the following call chain:
>
>idt77252_init_one
>  |-> idt77252_dev_open
>        |-> open_card_ubr0
>              |-> alloc_scq [failed]
>  |-> deinit_card
>        |-> vfree(card->vcs);
>
>card->vcs is freed and card->vcs[0] is leaked.
>
>Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>Signed-off-by: Zhipeng Lu <alexious@....edu.cn>

Reviewed-by: Jiri Pirko <jiri@...dia.com>