linux-kernel - Re: [PATCH] pinctrl: mcp23s08: Check only GPIOs which have interrupts enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ZbuaNwW1XwzaLB6X@smile.fi.intel.com>
Date: Thu, 1 Feb 2024 15:18:47 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Arturas Moskvinas <arturas.moskvinas@...il.com>
Cc: linus.walleij@...aro.org, u.kleine-koenig@...gutronix.de,
	radim.pavlik@...-biometrics.com, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: mcp23s08: Check only GPIOs which have
 interrupts enabled

On Thu, Feb 01, 2024 at 02:19:38PM +0200, Arturas Moskvinas wrote:
> On Thu, Feb 1, 2024 at 2:03 PM Andy Shevchenko <andriy.shevchenko@...el.com>
> wrote:

..

> > > +             /* We must check all of the inputs with enabled interrupts
> > > +              * on the chip, otherwise we may not notice a change
> > > +              * on >=2 pins.
> >
> > Missing space after =. But better to spell in proper English, i.e.
> > "...great than or equal to 2 pins."
> >
> +               /*
> +                * We must check all of the inputs with enabled interrupts
> +                * on the chip, otherwise we may not notice a change
> +                * on more than one pin.
> 
> Does this sound better?

LGTM, thanks.

-- 
With Best Regards,
Andy Shevchenko