linux-kernel - Re: [PATCH v3 5/8] ptp/kvm, arm_arch_timer: Set system_counterval_t.cs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afbd30fb-929e-4d17-97cd-e0456fe99f34@opensynergy.com>
Date: Thu, 1 Feb 2024 15:04:43 +0100
From: Peter Hilber <peter.hilber@...nsynergy.com>
To: Marc Zyngier <maz@...nel.org>
Cc: linux-kernel@...r.kernel.org,
 "D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@...el.com>,
 Thomas Gleixner <tglx@...utronix.de>, jstultz@...gle.com,
 giometti@...eenne.com, corbet@....net, "Dong, Eddie" <eddie.dong@...el.com>,
 "Hall, Christopher S" <christopher.s.hall@...el.com>,
 Simon Horman <horms@...nel.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-arm-kernel@...ts.infradead.org, Sean Christopherson
 <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
 "H. Peter Anvin" <hpa@...or.com>, Wanpeng Li <wanpengli@...cent.com>,
 Vitaly Kuznetsov <vkuznets@...hat.com>, Mark Rutland <mark.rutland@....com>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Richard Cochran <richardcochran@...il.com>, kvm@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH v3 5/8] ptp/kvm, arm_arch_timer: Set
 system_counterval_t.cs_id to constant

On 01.02.24 14:52, Marc Zyngier wrote:
> On Thu, 01 Feb 2024 01:04:50 +0000,
> Peter Hilber <peter.hilber@...nsynergy.com> wrote:
>>
>> Identify the clocksources used by ptp_kvm by setting clocksource ID enum
>> constants. This avoids dereferencing struct clocksource. Once the
>> system_counterval_t.cs member will be removed, this will also avoid the
>> need to obtain clocksource pointers from kvm_arch_ptp_get_crosststamp().
>>
>> The clocksource IDs are associated to timestamps requested from the KVM
>> hypervisor, so the proper clocksource ID is known at the ptp_kvm request
>> site.
>>
>> While at it, also rectify the ptp_kvm_get_time_fn() ret type.
> 
> Not sure what is wrong with that return type, but this patch doesn't
> seem to affect it.
> 

I meant to refer to the type of the variable ret declared in
ptp_kvm_get_time_fn(). I will reword the commit message to make this clear.

Thanks for the comment,

Peter