[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <132e22b9-2e42-4d8d-a2ea-14023bd5dae1@amd.com>
Date: Thu, 1 Feb 2024 09:35:13 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: yazen.ghannam@....com, tony.luck@...el.com, linux-edac@...r.kernel.org,
linux-kernel@...r.kernel.org, avadhut.naik@....com, john.allen@....com,
muralidhara.mk@....com
Subject: Re: [PATCH] RAS/AMD/ATL: Add MI300 DRAM to Normalized address
translation support
On 2/1/2024 4:21 AM, Borislav Petkov wrote:
> On Wed, Jan 31, 2024 at 10:57:32AM -0600, Yazen Ghannam wrote:
>> diff --git a/drivers/ras/amd/atl/umc.c b/drivers/ras/amd/atl/umc.c
>> index 7bfa21a582f0..816c2c5c683f 100644
>> --- a/drivers/ras/amd/atl/umc.c
>> +++ b/drivers/ras/amd/atl/umc.c
>> @@ -49,6 +49,203 @@ static u8 get_coh_st_inst_id_mi300(struct atl_err *err)
>> return i;
>> }
>>
>> +static u16 internal_bitwise_xor(u16 val)
>
> Why are we calling it "internal"?
>
It's an operation on the bits within a value rather than between two values.
BTW, I looked up "internal" in a thesaurus, and nothing seemed much better to me.
Maybe something like "xor_bits_in_value()"? This has the verb-first style too.
Thanks,
Yazen
Powered by blists - more mailing lists