linux-kernel - Re: [PATCH 1/1] RDMA/srpt: Do not register event handler until srpt device is fully setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <894db19d-5287-4ed8-a0d9-0211b365eafa@acm.org>
Date: Thu, 1 Feb 2024 06:48:34 -0800
From: Bart Van Assche <bvanassche@....org>
To: William Kucharski <william.kucharski@...cle.com>,
 Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
 linux-rdma@...r.kernel.org, target-devel@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] RDMA/srpt: Do not register event handler until srpt
 device is fully setup

On 1/30/24 22:24, William Kucharski wrote:
> Upon rare occasions, KASAN reports a use-after-free Write
> in srpt_refresh_port().
> 
> This seems to be because an event handler is registered before the
> srpt device is fully setup and a race condition upon error may leave a
> partially setup event handler in place.
> 
> Instead, only register the event handler after srpt device initialization
> is complete.

A Fixes: tag is missing. Otherwise this patch looks good to me. Hence:

Reviewed-by: Bart Van Assche <bvanassche@....org>