linux-kernel - Re: [PATCH net-next v6] bonding: Add independent control state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 01 Feb 2024 15:52:07 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Jay Vosburgh <jay.vosburgh@...onical.com>
Cc: Aahil Awatramani <aahila@...gle.com>, David Dillow
 <dave@...dillows.org>,  Mahesh Bandewar <maheshb@...gle.com>, Hangbin Liu
 <liuhangbin@...il.com>, Andy Gospodarek <andy@...yhouse.net>,  "David S .
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Martin KaFai Lau <martin.lau@...nel.org>,
 Herbert Xu <herbert@...dor.apana.org.au>, Daniel Borkmann
 <daniel@...earbox.net>,  netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6] bonding: Add independent control state
 machine

On Thu, 2024-02-01 at 06:43 -0800, Jay Vosburgh wrote:
> Paolo Abeni <pabeni@...hat.com> wrote:
> 
> > On Mon, 2024-01-29 at 20:27 +0000, Aahil Awatramani wrote:
> > > Add support for the independent control state machine per IEEE
> > > 802.1AX-2008 5.4.15 in addition to the existing implementation of the
> > > coupled control state machine.
> > > 
> > > Introduces two new states, AD_MUX_COLLECTING and AD_MUX_DISTRIBUTING in
> > > the LACP MUX state machine for separated handling of an initial
> > > Collecting state before the Collecting and Distributing state. This
> > > enables a port to be in a state where it can receive incoming packets
> > > while not still distributing. This is useful for reducing packet loss when
> > > a port begins distributing before its partner is able to collect.
> > 
> > If I read the code correctly, the transition
> > AD_MUX_COLLECTING_DISTRIBUTING -> AD_MUX_DISTRIBUTING is not possible,
> > am I correct?
> 
> 	That's correct.  There are two completely separate state
> machines in the 2008 standard, one for coupled control and one for
> independent control.  The state machines utilize the same states other
> than COLLECTING_DISTRIBUTING in the coupled control mode, and COLLECTING
> and DISTRIBUTING in the independent control mode.
> 
> 	Essentially, the two machines differ in the transition out from
> ATTACHED state; coupled control moves to COLLECTING_DISTRIBUTING,
> whereas independent control moves to COLLECTING then DISTRIBUTING.  
> 
> 	The 2020 edition of the standard combines the two state machines
> into one, and changes the set of states.  Bonding does not implement
> this version of the standard.

Thanks for the clarification, given that the patch LGTM!

Acked-by: Paolo Abeni <pabeni@...hat.com>