linux-kernel - Re: [PATCH v2 2/2] serial: mxs-auart: fix tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024020103-dictation-magma-d8ed@gregkh>
Date: Thu, 1 Feb 2024 06:57:17 -0800
From: Greg KH <gregkh@...uxfoundation.org>
To: Jiri Slaby <jirislaby@...nel.org>
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Emil Kronborg <emil.kronborg@...tonmail.com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Uwe Kleine-König <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	NXP Linux Team <linux-imx@....com>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] serial: mxs-auart: fix tx

On Thu, Feb 01, 2024 at 01:05:42PM +0100, Jiri Slaby wrote:
> On 01. 02. 24, 11:55, Jiri Slaby (SUSE) wrote:
> > Emil reports:
> >    After updating Linux on an i.MX28 board, serial communication over
> >    AUART broke. When I TX from the board and measure on the TX pin, it
> >    seems like the HW fifo is not emptied before the transmission is
> >    stopped.
> > 
> > MXS performs weird things with stop_tx(). The driver makes it
> > conditional on uart_tx_stopped().
> > 
> > So the driver needs special handling. Pass the brand new UART_TX_NOSTOP
> > to uart_port_tx_flags() and handle the stop on its own.
> > 
> > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> > Reported-by: Emil Kronborg <emil.kronborg@...tonmail.com>
> > Fixes: 2d141e683e9a ("tty: serial: use uart_port_tx() helper")
> > Closes: https://lore.kernel.org/all/miwgbnvy3hjpnricubg76ytpn7xoceehwahupy25bubbduu23s@om2lptpa26xw/
> 
> Am I unable to send a proper patch anymore?
> 
> I forgot to add mxs+arm maintainers:
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Pengutronix Kernel Team <kernel@...gutronix.de>
> Cc: Fabio Estevam <festevam@...il.com>
> Cc: NXP Linux Team <linux-imx@....com>
> Cc: linux-arm-kernel@...ts.infradead.org
> 
> I can resend with those fixed, if you prefer...

Nah, this is fine, I'll take this as-is, thanks!

greg k-h