linux-kernel - Re: [PATCH v2] pinctrl: mcp23s08: Check only GPIOs which have interrupts enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZburBq7ZJhK_X_t0@smile.fi.intel.com>
Date: Thu, 1 Feb 2024 16:30:30 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Arturas Moskvinas <arturas.moskvinas@...il.com>
Cc: linus.walleij@...aro.org, biju.das.jz@...renesas.com,
	akaessens@...il.com, thomas.preston@...ethink.co.uk,
	preid@...ctromag.com.au, u.kleine-koenig@...gutronix.de,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: mcp23s08: Check only GPIOs which have
 interrupts enabled

On Thu, Feb 01, 2024 at 04:14:07PM +0200, Arturas Moskvinas wrote:
> GPINTEN register contains information about GPIOs with enabled
> interrupts no need to check other GPIOs for changes.
> 
> Signed-off-by: Arturas Moskvinas <arturas.moskvinas@...il.com>
> ---

You forgot to add a changelog here, but no need to resend, just you can respond
to the email since it's not a big issue in this case.

..

> +	if (mcp_read(mcp, MCP_GPINTEN, &gpinten))
> +		goto unlock;

Do all hw variants have this register available?
Esp. I2C part, wouldn't it be problematic (exception with NACK on the bus)?

..

The rest LGTM, thanks!

-- 
With Best Regards,
Andy Shevchenko