linux-kernel - Re: [PATCH -next] ksmbd: Add kernel-doc for ksmbd_extract

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 2 Feb 2024 08:15:19 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Yang Li <yang.lee@...ux.alibaba.com>, linkinjeon@...nel.org,
 sfrench@...ba.org
Cc: senozhatsky@...omium.org, tom@...pey.com, linux-cifs@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ksmbd: Add kernel-doc for ksmbd_extract_sharename()
 function



On 2/2/24 00:13, Yang Li wrote:
> The ksmbd_extract_sharename() function lacked a complete kernel-doc
> comment. This patch adds parameter descriptions and detailed function
> behavior to improve code readability and maintainability.
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  fs/smb/server/misc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/smb/server/misc.c b/fs/smb/server/misc.c
> index 9e8afaa686e3..1a5faa6f6e7b 100644
> --- a/fs/smb/server/misc.c
> +++ b/fs/smb/server/misc.c
> @@ -261,6 +261,7 @@ char *ksmbd_casefold_sharename(struct unicode_map *um, const char *name)
>  
>  /**
>   * ksmbd_extract_sharename() - get share name from tree connect request
> + * @um: pointer to a unicode_map structure for character encoding handling
>   * @treename:	buffer containing tree name and share name
>   *
>   * Return:      share name on success, otherwise error

-- 
#Randy