linux-kernel - Re: [PATCH 1/2] efi: runtime: Fix potential overflow of soft-reserved region size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 2 Feb 2024 17:37:24 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Andrew Bresticker <abrestic@...osinc.com>
Cc: Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, linux-efi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 1/2] efi: runtime: Fix potential overflow of soft-reserved
 region size

Hi Andrew,

On Fri, 2 Feb 2024 at 17:34, Andrew Bresticker <abrestic@...osinc.com> wrote:
>
> md_size will have been narrowed if we have >= 4GB worth of pages in a
> soft-reserved region.
>
> Signed-off-by: Andrew Bresticker <abrestic@...osinc.com>
> ---
>  drivers/firmware/efi/arm-runtime.c   | 2 +-
>  drivers/firmware/efi/riscv-runtime.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
> index 83f5bb57fa4c..f369256c7003 100644
> --- a/drivers/firmware/efi/arm-runtime.c
> +++ b/drivers/firmware/efi/arm-runtime.c
> @@ -107,7 +107,7 @@ static int __init arm_enable_runtime_services(void)
>                 efi_memory_desc_t *md;
>
>                 for_each_efi_memory_desc(md) {
> -                       int md_size = md->num_pages << EFI_PAGE_SHIFT;
> +                       unsigned long md_size = md->num_pages << EFI_PAGE_SHIFT;

Better use u64 here, and below as well.


>                         struct resource *res;
>
>                         if (!(md->attribute & EFI_MEMORY_SP))
> diff --git a/drivers/firmware/efi/riscv-runtime.c b/drivers/firmware/efi/riscv-runtime.c
> index 09525fb5c240..9da79b8169d2 100644
> --- a/drivers/firmware/efi/riscv-runtime.c
> +++ b/drivers/firmware/efi/riscv-runtime.c
> @@ -85,7 +85,7 @@ static int __init riscv_enable_runtime_services(void)
>                 efi_memory_desc_t *md;
>
>                 for_each_efi_memory_desc(md) {
> -                       int md_size = md->num_pages << EFI_PAGE_SHIFT;
> +                       unsigned long md_size = md->num_pages << EFI_PAGE_SHIFT;
>                         struct resource *res;
>
>                         if (!(md->attribute & EFI_MEMORY_SP))
> --
> 2.34.1
>
>