[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 2 Feb 2024 19:53:24 +0100
From: Lorenzo Pieralisi <lpieralisi@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: manivannan.sadhasivam@...aro.org, bhelgaas@...gle.com,
conor+dt@...nel.org, devicetree@...r.kernel.org, festevam@...il.com,
helgaas@...nel.org, hongxing.zhu@....com, imx@...ts.linux.dev,
kernel@...gutronix.de, krzysztof.kozlowski+dt@...aro.org,
krzysztof.kozlowski@...aro.org, kw@...ux.com,
l.stach@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
linux-imx@....com, linux-kernel@...r.kernel.org,
linux-pci@...r.kernel.org, robh@...nel.org, s.hauer@...gutronix.de,
shawnguo@...nel.org
Subject: Re: [PATCH v9 05/16] PCI: imx6: Using "linux,pci-domain" as slot ID
On Fri, Feb 02, 2024 at 08:25:58AM -0500, Frank Li wrote:
> On Fri, Feb 02, 2024 at 01:12:41PM +0100, Lorenzo Pieralisi wrote:
> > "PCI: imx6: Use "linux,pci-domain" as slot ID"
> >
> > On Fri, Jan 19, 2024 at 12:11:11PM -0500, Frank Li wrote:
> > > Avoid use get slot id by compared with register physical address. If there
> > > are more than 2 slots, compared logic will become complex.
> > >
> > > "linux,pci-domain" already exist at dts since commit:
> > > commit (c0b70f05c87f3b arm64: dts: imx8mq: use_dt_domains for pci node).
> > >
> > > So it is safe to remove compare basic address code:
> > > ...
> > > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> > > imx6_pcie->controller_id = 1;
> >
> > No it is not unless you magically update all firmware out
> > there in the field.
>
> commit c0b70f05c87f3b09b391027c6f056d0facf331ef
> Author: Peng Fan <peng.fan@....com>
> AuthorDate: Fri Jan 15 11:26:57 2021 +0800
> Commit: Shawn Guo <shawnguo@...nel.org>
> CommitDate: Fri Jan 29 14:46:28 2021 +0800
>
> I am not sure if it is neccesary to compatible with 2 years ago's dts.
> I think it may not boot at all with using 2 year agao dtb file directly.
>
> Do you have other comments? I can remove it from this big patch series,
I will have a look at the full series first we can decide whether
to drop it later.
I am travelling so I am not sure I can review it before February
12th, FYI.
Lorenzo
Powered by blists - more mailing lists