linux-kernel - Re: [PATCH v4 3/3] hwmon: Add driver for Astera Labs PT5161L retimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 2 Feb 2024 11:05:39 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Cosmo Chou <chou.cosmo@...il.com>
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, jdelvare@...e.com, corbet@....net,
	broonie@...nel.org, naresh.solanki@...ements.com,
	vincent@...emblay.dev, patrick.rudolph@...ements.com,
	luca.ceresoli@...tlin.com, bhelgaas@...gle.com, festevam@...x.de,
	alexander.stein@...tq-group.com, heiko@...ech.de,
	jernej.skrabec@...il.com, macromorgan@...mail.com,
	forbidden405@...mail.com, sre@...nel.org, linus.walleij@...aro.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
	cosmo.chou@...ntatw.com
Subject: Re: [PATCH v4 3/3] hwmon: Add driver for Astera Labs PT5161L retimer

On Mon, Jan 15, 2024 at 06:05:18PM +0800, Cosmo Chou wrote:
> This driver implements support for temperature monitoring of Astera Labs
> PT5161L series PCIe retimer chips.
> 
> This driver implementation originates from the CSDK available at
> Link: https://github.com/facebook/openbmc/tree/helium/common/recipes-lib/retimer-v2.14
> The communication protocol utilized is based on the I2C/SMBus standard.
> 
> Signed-off-by: Cosmo Chou <chou.cosmo@...il.com>

That gives me:

WARNING: Improper SPDX comment style for 'drivers/hwmon/pt5161l.c', please use '//' instead
#237: FILE: drivers/hwmon/pt5161l.c:1:
+/* SPDX-License-Identifier: GPL-2.0-or-later */

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#237: FILE: drivers/hwmon/pt5161l.c:1:
+/* SPDX-License-Identifier: GPL-2.0-or-later */

CHECK: struct mutex definition without comment
#304: FILE: drivers/hwmon/pt5161l.c:68:
+	struct mutex lock;

CHECK: Lines should not end with a '('
#419: FILE: drivers/hwmon/pt5161l.c:183:
+		ret = pt5161l_write_block_data(

and many more of the latter. I'd fix it up if it was just one or two,
and I don't care about the mutex definition comment, but

	total: 0 errors, 2 warnings, 9 checks, 755 lines checked

is just too much.

>From Documentation/hwmon/submitting-patches.rst:

* Please run your patch through 'checkpatch --strict'. There should be no
  errors, no warnings, and few if any check messages. If there are any
  messages, please be prepared to explain.

Please fix and resubmit. No need to resubmit the other patches in the
series, since I already applied those.

Thanks,
Guenter