[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 2 Feb 2024 14:25:14 -0800
From: Nhat Pham <nphamcs@...il.com>
To: Chengming Zhou <zhouchengming@...edance.com>
Cc: Johannes Weiner <hannes@...xchg.org>, Andrew Morton <akpm@...ux-foundation.org>,
Yosry Ahmed <yosryahmed@...gle.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/6] mm/zswap: add more comments in shrink_memcg_cb()
On Thu, Feb 1, 2024 at 7:50 AM Chengming Zhou
<zhouchengming@...edance.com> wrote:
>
> Add more comments in shrink_memcg_cb() to describe the deref dance
> which is implemented to fix race problem between lru writeback and
> swapoff, and the reason why we rotate the entry at the beginning.
>
> Also fix the stale comments in zswap_writeback_entry(), and add
> more comments to state that we only deref the tree after we get
> the swapcache reference.
>
> Suggested-by: Yosry Ahmed <yosryahmed@...gle.com>
> Suggested-by: Johannes Weiner <hannes@...xchg.org>
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
> ---
Reviewed-by: Nhat Pham <nphamcs@...il.com>
Powered by blists - more mailing lists