lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 2 Feb 2024 17:20:46 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Unnathi Chalicheemala <quic_uchalich@...cinc.com>, 
	Konrad Dybcio <konrad.dybcio@...aro.org>, Satya Durga Srinivasu Prabhala <quic_satyap@...cinc.com>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...cinc.com, 
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: Re: [PATCH] soc: qcom: llcc: Check return value on Broadcast_OR
 reg read

On Fri, Feb 02, 2024 at 11:56:53AM -0800, Elliot Berman wrote:
> On Fri, Feb 02, 2024 at 11:47:43AM -0800, Unnathi Chalicheemala wrote:
> > Commit a3134fb09e0b ("drivers: soc: Add LLCC driver") didn't
> > check return value after Broadcast_OR register read in
> > llcc_update_act_ctrl(), add it.
> > 
> 
> Reviewed-by: Elliot Berman <quic_eberman@...cinc.com>
> 
> You'll probably want to add:
> 
> Fixes: a3134fb09e0b ("drivers: soc: Add LLCC driver")

No, this was correct in a3134fb09e0b, ret was returned on the following
line. The problem was introduced when the new 4.1 if statement was
introduced without considering that ret might be overwritten.

Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")

Regards,
Bjorn

> 
> > Signed-off-by: Unnathi Chalicheemala <quic_uchalich@...cinc.com>
> > ---
> >  drivers/soc/qcom/llcc-qcom.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> > index 4ca88eaebf06..cbef0dea1d5d 100644
> > --- a/drivers/soc/qcom/llcc-qcom.c
> > +++ b/drivers/soc/qcom/llcc-qcom.c
> > @@ -859,6 +859,8 @@ static int llcc_update_act_ctrl(u32 sid,
> >  	ret = regmap_read_poll_timeout(drv_data->bcast_regmap, status_reg,
> >  				      slice_status, !(slice_status & status),
> >  				      0, LLCC_STATUS_READ_DELAY);
> > +	if (ret)
> > +		return ret;
> >  
> >  	if (drv_data->version >= LLCC_VERSION_4_1_0_0)
> >  		ret = regmap_write(drv_data->bcast_regmap, act_clear_reg,
> > 
> > ---
> > base-commit: 021533194476035883300d60fbb3136426ac8ea5
> > change-id: 20240202-fix_llcc_update_act_ctrl-64908aed9450
> > 
> > Best regards,
> > -- 
> > Unnathi Chalicheemala <quic_uchalich@...cinc.com>
> > 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ