linux-kernel - Re: [PATCH 3/3] drm/amdgpu: wire up the can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 2 Feb 2024 15:40:03 -0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Hamza Mahfooz <hamza.mahfooz@....com>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	"Pan, Xinhui" <Xinhui.Pan@....com>,
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Mario Limonciello <mario.limonciello@....com>,
	Lijo Lazar <lijo.lazar@....com>,
	Srinivasan Shanmugam <srinivasan.shanmugam@....com>,
	Le Ma <le.ma@....com>,
	André Almeida <andrealmeid@...lia.com>,
	James Zhu <James.Zhu@....com>,
	Aurabindo Pillai <aurabindo.pillai@....com>,
	Alex Shi <alexs@...nel.org>, Jerry Snitselaar <jsnitsel@...hat.com>,
	Wei Liu <wei.liu@...nel.org>, Robin Murphy <robin.murphy@....com>,
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 3/3] drm/amdgpu: wire up the can_remove() callback

On Fri, Feb 02, 2024 at 05:25:56PM -0500, Hamza Mahfooz wrote:
> Removing an amdgpu device that still has user space references allocated
> to it causes undefined behaviour.

Then fix that please.  There should not be anything special about your
hardware that all of the tens of thousands of other devices can't handle
today.

What happens when I yank your device out of a system with a pci hotplug
bus?  You can't prevent that either, so this should not be any different
at all.

sorry, but please, just fix your driver.

greg k-h