linux-kernel - Re: [PATCH] soc: qcom: mdt_loader: Add Upperbounds check for program header access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 2 Feb 2024 12:07:12 +0530
From: Auditya Bhattaram <quic_audityab@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <andersson@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: qcom: mdt_loader: Add Upperbounds check for program
 header access



On 2/1/2024 8:20 PM, Konrad Dybcio wrote:
> On 31.01.2024 10:42, Auditya Bhattaram wrote:
>> hash_index is evaluated by looping phdrs till QCOM_MDT_TYPE_HASH
>> is found. Add an upperbound check to phdrs to access within elf size.
>>
>> Signed-off-by: Auditya Bhattaram <quic_audityab@...cinc.com>
>> ---
> 
> Could you print an error when this happens? There's a lot of EINVALs
> in the MDT loader codepaths, but you never know which one fired..
> 
> Konrad

Sure, will add error prints