linux-kernel - RE: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <CY4PR1801MB191155E0D21759A56CA0B8B6D3422@CY4PR1801MB1911.namprd18.prod.outlook.com>
Date: Fri, 2 Feb 2024 07:32:40 +0000
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Simon Horman <horms@...nel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "bcreeley@....com" <bcreeley@....com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Hariprasad
 Kelam <hkelam@...vell.com>,
        Suman Ghosh <sumang@...vell.com>
Subject: RE: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.

>From: Jakub Kicinski <kuba@...nel.org>
> Subject: Re: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
> 
> On Thu, 1 Feb 2024 09:35:15 +0000 Ratheesh Kannoth wrote:
> > > The use of bitmap_zalloc()/bitmap_free() looks good to me.
> > > But for the kmalloc_array(..., GFP_KERNEL | __GFP_ZERO) cases I
> > > think
> > > kcalloc() is the way to go.
> > Kcalloc() is a wrapper around kmalloc_array().  Why do you think
> > kcalloc() Is better ?
> 
> Are you genuinely asking for an explanation why
> kcalloc() is better than kmalloc_array()? 
Yes.

>It's an equivalent to the standard C
> function, calloc().
Thanks. 
> 
> The reviewers are the most valuable part of this community, we will not take
> frustrating them lightly :|
I learn a lot from review comments provided by this community and do value 
them. I am sorry if my "English" sounded harsh.