lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 2 Feb 2024 08:29:05 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Biju Das <biju.das.jz@...renesas.com>, Claudiu.Beznea
	<claudiu.beznea@...on.dev>, "wim@...ux-watchdog.org"
	<wim@...ux-watchdog.org>, "linux@...ck-us.net" <linux@...ck-us.net>,
	"robh@...nel.org" <robh@...nel.org>, "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"geert+renesas@...der.be" <geert+renesas@...der.be>, "magnus.damm@...il.com"
	<magnus.damm@...il.com>
CC: "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	Claudiu.Beznea <claudiu.beznea@...on.dev>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>
Subject: RE: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM

> > -----Original Message-----
> > From: Biju Das
> > Sent: Friday, February 2, 2024 8:03 AM
> > Subject: RE: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM
> >
> > Hi Claudiu Beznea,
> >
> > > -----Original Message-----
> > > From: Claudiu <claudiu.beznea@...on.dev>
> > > Sent: Friday, February 2, 2024 7:59 AM
> > > Subject: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM
> > >
> > > From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> > >
> > > The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
> > > clocks are enabled though pm_runtime_* specific APIs). To avoid
> > > building a driver that doesn't work make it depend on CONFIG_PM.
> > >
> > > Suggested-by: Guenter Roeck <linux@...ck-us.net>
> > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> > > ---
> > >
> > > Changes in v3:
> > > - make driver depend on PM; with that the "unmet direct dependency"
> > >   Reported-by: kernel test robot <lkp@...el.com>
> > >   was also fixed
> > > - adapt commit message
> > >
> > > Changes in v2:
> > > - this patch is new
> > >
> > >  drivers/watchdog/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > > index 7d22051b15a2..c9abe8f307bb 100644
> > > --- a/drivers/watchdog/Kconfig
> > > +++ b/drivers/watchdog/Kconfig
> > > @@ -910,7 +910,7 @@ config RENESAS_RZN1WDT
> > >
> > >  config RENESAS_RZG2LWDT
> > >  	tristate "Renesas RZ/G2L WDT Watchdog"
> > > -	depends on ARCH_RENESAS || COMPILE_TEST
> > > +	depends on (ARCH_RENESAS && PM) || COMPILE_TEST
> >
> > Since you are touching here, maybe ARCH_RZG2L?? like other RZ/G2L
> drivers.
> 
> Also RZ/V2M "ARCH_R9A09G011" as both these families using same driver.

Also commit header it is "Depend on" not "Select"?

Cheers,
Biju

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ