[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZbypkC/y1einkKmw@gondor.apana.org.au>
Date: Fri, 2 Feb 2024 16:36:32 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: JiaJie Ho <jiajie.ho@...rfivetech.com>
Cc: "'David S . Miller'" <davem@...emloft.net>,
'Rob Herring' <robh+dt@...nel.org>,
'Krzysztof Kozlowski' <krzysztof.kozlowski+dt@...aro.org>,
'Conor Dooley' <conor+dt@...nel.org>,
"'linux-crypto@...r.kernel.org'" <linux-crypto@...r.kernel.org>,
"'devicetree@...r.kernel.org'" <devicetree@...r.kernel.org>,
"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/5] crypto: starfive: Add sm3 support for JH8100
On Thu, Feb 01, 2024 at 06:40:09AM +0000, JiaJie Ho wrote:
>
> The object files defining these functions aren't included for CRYPTO_DEV_JH7110 in the Makefile.
> obj-$(CONFIG_CRYPTO_DEV_JH7110) += jh7110-crypto.o
> jh7110-crypto-objs := jh7110-cryp.o jh7110-hash.o jh7110-rsa.o jh7110-aes.o
>
> obj-$(CONFIG_CRYPTO_DEV_JH8100) += jh8100-crypto.o
> jh8100-crypto-objs := jh7110-cryp.o jh7110-hash.o jh7110-rsa.o jh7110-aes.o jh8100-sm3.o jh8100-sm4.o
What happens if someone enables/loads both drivers? If you want
to share code then that needs to be split out into a third module.
Cheers,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists