linux-kernel - Re: [PATCH printk v3 14/14] panic: Flush kernel log buffer at the end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 2 Feb 2024 10:30:32 +0100
From: Petr Mladek <pmladek@...e.com>
To: John Ogness <john.ogness@...utronix.de>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	"Guilherme G. Piccoli" <gpiccoli@...lia.com>,
	Kefeng Wang <wangkefeng.wang@...wei.com>,
	Kees Cook <keescook@...omium.org>, Uros Bizjak <ubizjak@...il.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH printk v3 14/14] panic: Flush kernel log buffer at the end

On Thu 2023-12-14 22:48:01, John Ogness wrote:
> If the kernel crashes in a context where printk() calls always
> defer printing (such as in NMI or inside a printk_safe section)
> then the final panic messages will be deferred to irq_work. But
> if irq_work is not available, the messages will not get printed
> unless explicitly flushed. The result is that the final
> "end Kernel panic" banner does not get printed.
> 
> Add one final flush after the last printk() call to make sure
> the final panic messages make it out as well.
> 
> Signed-off-by: John Ogness <john.ogness@...utronix.de>

Makes sense.

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr